Bug 309840 – [macOS Release] inspector/page/setShowPaintRects.html is a flaky text failure

• Component: Web Inspector
• Status: RESOLVED FIXED

[Diego De La Toba]

inspector/page/setShowPaintRects.html is a flaky text failure on macOS release.


HISTORY:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Fpage%2FsetShowPaintRects.html&style=release


DIFF:
--- /Volumes/Data/worker/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/build/layout-test-results/inspector/page/setShowPaintRects-expected.txt
+++ /Volumes/Data/worker/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/build/layout-test-results/inspector/page/setShowPaintRects-actual.txt
@@ -11,7 +11,11 @@
 
 -- Running test setup.
 -- Running test case: Page.setShowPaintRects.Disabled
-PASS: Should not have paint rects displayed.
-PASS: Should not have had any paint rects displayed.
+FAIL: Should not have paint rects displayed.
+    Expected: false
+    Actual: true
+FAIL: Should not have had any paint rects displayed.
+    Expected: falsey
+    Actual: true
 -- Running test teardown.
 

DIFF URL:
https://build.webkit.org/results/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/309157@main%20(2367)/inspector/page/setShowPaintRects-pretty-diff.html


REPRODUCTION
I was able to reproduce this on macOS release ToT with the following with high CPU usage:

run-webkit-tests --no-build --no-retry --no-show-results --exit-after-n-failures=1 --expect-pass --iterations=2000 --force -f --release inspector/page/setShowPaintRects.html 


I am going to mark expectations as pass fail while this pends investigation.

[Radar WebKit Bug Importer]

<rdar://problem/172419591>

[Diego De La Toba]

Test gardening pull request: https://github.com/WebKit/WebKit/pull/60525

[EWS]

Test gardening commit 309218@main (7260947b93d7): <https://commits.webkit.org/309218@main>

Reviewed commits have been landed. Closing PR #60525 and removing active labels.

[Diego De La Toba]

Looks like a fix was attempted at 251585@main where we deferred test results dump to the teardown so they dont trigger paints however there is a timing issue causing failures for in the second test. Sometimes while dumping results from the first test to the DOM, setShowPaintRects state is still true and subsequently paint rects are created that leak into the second test which expects no paint rects.

The fix here is to explicitly set setShowPaintRects to false before printing those results to DOM.

[Diego De La Toba]

Pull request: https://github.com/WebKit/WebKit/pull/60579

[EWS]

Committed 309265@main (9e68a23c4475): <https://commits.webkit.org/309265@main>

Reviewed commits have been landed. Closing PR #60579 and removing active labels.