Bug 309579
| Summary: | Perf tests CSS/HasWithChildCombinatorInIs.html and Layout/subgrids-spanning-many-rows.html fail due to visible text in output | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | hysu <hysu> |
| Component: | Tools / Tests | Assignee: | hysu <hysu> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
hysu
These two performance tests render visible text content ("Item 0" and "Row") that gets included in the dumpAsText output. The perf test runner treats any line that doesn't match the expected metrics format as an error, causing the tests to fail.
Example run: https://build.webkit.org/#/builders/1684/builds/1100
The fix is to remove the unnecessary visible text from both tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/172199389>
hysu
Pull request: https://github.com/WebKit/WebKit/pull/60280
EWS
Committed 309022@main (e2dcd48beed0): <https://commits.webkit.org/309022@main>
Reviewed commits have been landed. Closing PR #60280 and removing active labels.