Bug 309446
| Summary: | FileSystemWritableFileStream: WriteParams members should be non-nullable per updated spec | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | usamanadeemparacha |
| Component: | Website Storage | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | sihui_liu, usamanadeemparacha, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
usamanadeemparacha
The WHATWG File System spec has been updated to make the `size`, `position`, and `data` members of the `WriteParams` dictionary non-nullable.
Previously these were marked as nullable (`?`), but the `write()` algorithm never handles null values. Making them non-nullable means passing null will now throw a TypeError at the WebIDL boundary, which is the correct and intended behavior.
Spec change: https://github.com/whatwg/fs/pull/182
Related issue: https://github.com/whatwg/fs/issues/181
WPT tests: https://github.com/web-platform-tests/wpt/pull/58156
Please update the WebKit implementation so that passing null for `size`, `position`, or `data` in `WriteParams` throws a TypeError.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/172598363>
usamanadeemparacha
Hi any updates on the matter will be be helpful here, are you guys waiting for PR to be merged?
usamanadeemparacha
Hi any updates on the matter will be be helpful here, are you guys waiting for PR to be merged?
usamanadeemparacha
Hi its been really long and Im still waiting for the reply?