Bug 309282
| Summary: | [Tools][WPE] generate-bundle: skip generating the WebDriver binary wrapper if WebDriver support was not built | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | New Bugs | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Alberto Lopez Perez
If you build WPE with -DENABLE_WEBDRIVER=OFF and then try to use generate-bundle to generate a minibrowser bundle it ends with error:
Traceback (most recent call last):
File "/home/pwuser/webkit/Tools/Scripts/generate-bundle", line 979, in <module>
sys.exit(main())
~~~~^^
File "/home/pwuser/webkit/Tools/Scripts/generate-bundle", line 974, in main
bundle_file_path = bundle_creator.create()
File "/home/pwuser/webkit/Tools/Scripts/generate-bundle", line 357, in create
self._create_bundle(bundle_binary)
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/home/pwuser/webkit/Tools/Scripts/generate-bundle", line 908, in _create_bundle
self._generate_wrapper(interpreter, self._port_binary_preffix + 'WebDriver')
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/pwuser/webkit/Tools/Scripts/generate-bundle", line 308, in _generate_wrapper
self._bundler.generate_wrapper_script(interpreter, binary_to_wrap, variables)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/pwuser/webkit/Tools/Scripts/webkitpy/binary_bundling/bundle.py", line 352, in generate_wrapper_script
raise RuntimeError('Cannot find binary to wrap for %s' % binary_to_wrap)
RuntimeError: Cannot find binary to wrap for WebKitWebDriver
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/59998
EWS
Committed 308797@main (e2d19aaf515b): <https://commits.webkit.org/308797@main>
Reviewed commits have been landed. Closing PR #59998 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/171902820>