Bug 30927

Summary: [Qt] Remove the QWebInspector::windowTitleChanged signal
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, kenneth
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Jocelyn Turcotte
Reported 2009-10-29 14:00:08 PDT
Remove the QWebInspector::windowTitleChanged signal, QEvent::WindowTitleChange can be used to achieve the same.
Attachments
Patch (2.18 KB, patch)
2009-10-29 14:01 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2009-10-29 14:01:03 PDT
Created attachment 42141 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2009-10-29 14:19:20 PDT
LGTM. Maybe add this hint to the documentation of the class?
Tor Arne Vestbø
Comment 3 2009-10-30 08:25:15 PDT
Comment on attachment 42141 [details] Patch LGTM
WebKit Commit Bot
Comment 4 2009-10-30 10:50:55 PDT
Comment on attachment 42141 [details] Patch Clearing flags on attachment: 42141 Committed r50344: <http://trac.webkit.org/changeset/50344>
WebKit Commit Bot
Comment 5 2009-10-30 10:50:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.