Bug 309224
| Summary: | [Swift in WebKit] Enable a few upcoming Swift compiler features in all targets | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Richard Robinson <richard_robinson2> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | commit-queue, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 309356 | ||
| Bug Blocks: | |||
Richard Robinson
.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/171782289>
Richard Robinson
Pull request: https://github.com/WebKit/WebKit/pull/59950
EWS
Committed 308780@main (983a9cf2b6c0): <https://commits.webkit.org/308780@main>
Reviewed commits have been landed. Closing PR #59950 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 309356
Ryosuke Niwa
Sorry, I had to revert this change because it broke macOS safer C++ bot:
https://commits.webkit.org/308807@main
The error:
EmitSwiftModule normal arm64 (in target 'WebKitSwift' from project 'WebKit')
cd /Volumes/Data/worker/Apple-Sequoia-Safer-CPP-Checks/build/Source/WebKit
<unknown>:0: warning: unknown warning group: 'StrictMemorySafety'
<unknown>:0: warning: unknown warning group: 'StrictMemorySafety'
/Volumes/Data/worker/Apple-Sequoia-Safer-CPP-Checks/build/Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift:404:65: error: unknown attribute 'MainActor'
class PlatformIntelligenceRemainderAffordanceTextEffect<Chunk>: @MainActor PlatformIntelligenceTextEffect
^
/Volumes/Data/worker/Apple-Sequoia-Safer-CPP-Checks/build/Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift:538:57: error: unknown attribute 'MainActor'
class PlatformIntelligenceReplacementTextEffect<Chunk>: @MainActor PlatformIntelligenceTextEffect
^
/Volumes/Data/worker/Apple-Sequoia-Safer-CPP-Checks/build/Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift:658:55: error: unknown attribute 'MainActor'
class PlatformIntelligencePonderingTextEffect<Chunk>: @MainActor PlatformIntelligenceTextEffect
^