Summary: | [V8] Remove random crashes by removing retrieval of V8 context during garbage collection. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||||||
Component: | WebCore JavaScript | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, ager, eric, sgjesse | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2009-10-29 11:35:45 PDT
Created attachment 42117 [details]
Fixerate random crashes, v1.
Created attachment 42120 [details]
Fixerate random crashes, v2.
Comment on attachment 42120 [details]
Fixerate random crashes, v2.
+ V8DOMWrapper::jsWrapperForDOMObject
We should have two of these: one for DOMObjects and one for ActiveDOMObjects, to mirror the setters.
Created attachment 42124 [details]
Fixerate random crashes, v3.
Comment on attachment 42124 [details]
Fixerate random crashes, v3.
Thanks.
Nit: I Don't think it it's required retrieve port1Wrapper, as it is already in wrapper, that is v8::Handle<v8::Value> port1Wrapper = V8DOMWrapper::jsWrapperForActiveDOMObject(port1); could be v8::Handle<v8::Value> port1Wrapper = wrapper or the variable port1Wrapper could be removed. Comment on attachment 42124 [details]
Fixerate random crashes, v3.
Rejecting patch 42124 from commit-queue.
Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Adam Barth', '--force']" exit_code: 1
Last 500 characters of output:
geLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/bindings/v8/V8DOMWrapper.cpp
Hunk #1 succeeded at 208 with fuzz 1 (offset 54 lines).
patching file WebCore/bindings/v8/V8DOMWrapper.h
Hunk #1 FAILED at 279.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/bindings/v8/V8DOMWrapper.h.rej
patching file WebCore/bindings/v8/V8GCController.cpp
Hunk #1 FAILED at 218.
Hunk #2 FAILED at 228.
2 out of 2 hunks FAILED -- saving rejects to file WebCore/bindings/v8/V8GCController.cpp.rej
Comment on attachment 42124 [details]
Fixerate random crashes, v3.
Rejecting patch 42124 from commit-queue.
Failed to run "['/Users/abarth/git/webkit-kr/WebKitTools/Scripts/svn-apply', '--reviewer', 'Adam Barth']" exit_code: 1
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/bindings/v8/V8DOMWrapper.cpp
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file WebCore/bindings/v8/V8DOMWrapper.cpp.rej
patch -p0 "WebCore/bindings/v8/V8DOMWrapper.cpp" returned 1. Pass --force to ignore patch failures.
Ping? Looks like we need a new patch here. Comment on attachment 42124 [details]
Fixerate random crashes, v3.
Changing Adam Barth's r+ to an r- since this patch no longer applies. We need a new patch.
I mean, I guess if Dimitri plans to land this himself, that's totally fine and he should consider it still r+'d by Adam, but not having been touched in nearly 2 months, it's silly to have this still sitting in the pending-commit list. That's assuming this bug should even still be open? I stink. Landed as http://trac.webkit.org/changeset/50293. |