Bug 309054
| Summary: | Remove SVGUnknownElement WPT test case which is not part of SVG2 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | SVG | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=309138 https://github.com/web-platform-tests/wpt/pull/58245 |
||
Karl Dubost
Removed SVGUnknownElement due to lack of implementations.
https://w3c.github.io/svgwg/svg2-draft/single-page.html#:~:text=Removed%20SVGUnknownElement%20due%20to%20lack%20of%20implementations.
This test needs to be removed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
The test is https://wpt.fyi/results/svg/struct/UnknownElement/interface.svg
Radar WebKit Bug Importer
<rdar://problem/171604924>
Karl Dubost
I realized.
There is an SVGUnknownElement implementation
https://searchfox.org/wubkat/search?q=SVGUnknownElement&path=&case=false®exp=false
Not called from anywhere though. So I thought let's remove it.
Source/WebCore/svg/SVGUnknownElement.cpp
Source/WebCore/svg/SVGUnknownElement.h
But then I found:
https://searchfox.org/wubkat/rev/f9409a9efaa94496294843a103b04c45487df72f/Source/WebCore/svg/svgtags.in#3-11
```
fallbackInterfaceName="SVGUnknownElement"
fallbackJSInterfaceName="SVGElement"
a
altGlyph JSInterfaceName=SVGElement
altGlyphDef JSInterfaceName=SVGElement
altGlyphItem JSInterfaceName=SVGElement
animate
animateColor interfaceName=SVGUnknownElement, JSInterfaceName=SVGElement, noConstructor
```
what is the purpose of animateColor here and its interface with SVGUnknownElement?
Oh it's when @Ahmad Saleem tried to remove animateColor.
https://searchfox.org/wubkat/diff/1674e8f0e5b811710ca6f0b03e4d708a53768958/Source/WebCore/svg/svgtags.in#11
https://github.com/WebKit/WebKit/commit/1674e8f0e5b811710ca6f0b03e4d708a53768958
https://github.com/WebKit/WebKit/pull/25671
I could just remove the test. But now I'm looking at it, I wonder if we could remove the SVGUnknownElement too.
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/59789
EWS
Committed 308619@main (097af8a9cdec): <https://commits.webkit.org/308619@main>
Reviewed commits have been landed. Closing PR #59789 and removing active labels.
Karl Dubost
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/58245