Summary: | [Gtk] Need to de-lint the Atk a11y code | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Trivial | CC: | commit-queue, jmalonzo, xan.lopez | ||||||
Priority: | P5 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Joanmarie Diggs
2009-10-28 23:06:05 PDT
Created attachment 42813 [details]
proposed patch
Discovered a signed/unsigned comparison warning that I was responsible for. :-/ Seemed like a good excuse to de-lint... :-)
* NULL should be 0
* Caps in keeping with the style guidelines
* Remove trailing whitespace
* No space between the pointer type and the '*'
* Remove the aforementioned signed/unsigned comparison
Comment on attachment 42813 [details]
proposed patch
Thanks for the cleanup. r=me.
Comment on attachment 42813 [details] proposed patch Clearing flags on attachment: 42813 Committed r50727: <http://trac.webkit.org/changeset/50727> All reviewed patches have been landed. Closing bug. Reopening because I found another handful of capitalization style-guideline violations I had missed and just don't see opening a new bug. Created attachment 42921 [details]
Correct some capitalization nits
Comment on attachment 42921 [details]
Correct some capitalization nits
r=me.
Comment on attachment 42921 [details] Correct some capitalization nits Clearing flags on attachment: 42921 Committed r50797: <http://trac.webkit.org/changeset/50797> All reviewed patches have been landed. Closing bug. |