Bug 308941
| Summary: | Update WeakPtr threading assertions to catch more bugs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 309074 | ||
| Bug Blocks: | |||
Chris Dumez
Update WeakPtr threading assertions to catch more bugs:
- Leverage ThreadLikeAssertion instead of a simple `wasConstructedOnMainThread` boolean to distinguish different threads / work queues.
- Promote assertion to ASSERT_WITH_SECURITY_IMPLICATION
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/59686
EWS
Committed 308485@main (293a7d44cdd5): <https://commits.webkit.org/308485@main>
Reviewed commits have been landed. Closing PR #59686 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/171562170>
Jonathan Bedard
Reopened Bugzilla.
REGRESSION(308485@main): Use of undeclared identifier 'm_shouldEnableAssertions', tracking revert in https://bugs.webkit.org/show_bug.cgi?id=309074.
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/59836
EWS
Committed 308610@main (10945fb82e3a): <https://commits.webkit.org/308610@main>
Reviewed commits have been landed. Closing PR #59836 and removing active labels.