Bug 308790
| Summary: | [CMake] Add missing dependencies to GENERATE_IDL_BINDINGS macro | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WPE WebKit | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Alberto Lopez Perez
After 308310@main the iterative build broke on some WPE bots like https://build.webkit.org/#/builders/894/builds/32521
The problem is that 308310@main updated the script CodeGeneratorExtensions.pm and that should have trig-erred a regeneration of the JSWebExtensionAPI*.h files.
But current CMake GENERATE_IDL_BINDINGS macro does not list CodeGeneratorExtensions.pm (or the other binding scripts) in its DEPENDS list. As a result, CMake did not know to regenerate the JSWebExtensionAPI*.h files when the generator script changed, leaving stale generated headers that still declared the old runtimeClass() name while the macros now expected runtimeClassSingleton()
Let's fix this
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/59554
EWS
Committed 308329@main (58cfbf6a335a): <https://commits.webkit.org/308329@main>
Reviewed commits have been landed. Closing PR #59554 and removing active labels.