Bug 308749
| Summary: | Switch emit-clang-header-min-access to be SDK based | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | adrian_taylor |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
adrian_taylor
We use the Swift compiler flag '-emit-clang-header-min-access internal' to ensure we don't put Swift implementation details into WebKit's public API. We previously flipped this switch based upon whether ENABLE_BACK_FORWARD_LIST_SWIFT or ENABLE_IPC_TESTING_SWIFT was turned on; it's seen as desirable to move those flags into wtf/PlatformEnable.h instead, so we can't rely on them in xcconfig files - instead enable this option on sufficiently recent SDKs irrespective of whether these flags are flipped.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/171266342>
adrian_taylor
Pull request: https://github.com/WebKit/WebKit/pull/59511
EWS
Committed 308427@main (09598407876c): <https://commits.webkit.org/308427@main>
Reviewed commits have been landed. Closing PR #59511 and removing active labels.