Bug 308744
| Summary: | clearItems() consistency across SVG list types | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | SVG | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Karl Dubost
svg/SVGStringList.cpp
svg/SVGLengthList.cpp
svg/SVGNumberList.cpp
svg/SVGPointList.cpp
All four list types ask the same question:
// FIXME: Should this clearItems() on failure like SVGTransformList does?
SVGTransformList already has the correct behavior.
The fix is mechanical: add clearItems() in the failure path of each parse method.
But are there tests to make sure that this is the behavior of other browsers.
This would be probably the first step.
1. Create a WPT test
2. Check with other browsers
3. Fix eventually.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/171263290>
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/59513
EWS
Committed 308438@main (a4d918a0ff56): <https://commits.webkit.org/308438@main>
Reviewed commits have been landed. Closing PR #59513 and removing active labels.