Bug 308695
| Summary: | [libpas] Make pas_{small,tiny}_large_map_entry aware of delegation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://170836116
When non-delegated allocations are stored in the large-heap, it is
possible that their metadata will be stored in the tiny_large_map
or the small_large_map, which are compressed versions of the normal
large-map.
When this happens, we need to ensure that at the point the large-map
reconstructs a large_map_entry from the compressed contents of those
heaps, it populates all fields in the entry, as the entry is not
guaranteed to be zero-filled beforehand. Otherwise, the
delegated_to_system_malloc field could be filled with garbage, leading
to an inevitable crash when we free the pointer from libmalloc.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/59473
Marcus Plutowski
<rdar://problem/170300268>
EWS
Committed 308296@main (f209caf4db12): <https://commits.webkit.org/308296@main>
Reviewed commits have been landed. Closing PR #59473 and removing active labels.
EWS
Committed 305413.380@safari-7624-branch (8e3eb903d2f8): <https://commits.webkit.org/305413.380@safari-7624-branch>
Reviewed commits have been landed. Closing PR #4576 and removing active labels.