Bug 308571
| Summary: | REGRESSION(306469@main) [WebDriver] Fix browsing context state tracking after waitForNavigationToComplete returns WindowNotFound for frames | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
WebDriver::Session::waitForNavigationToComplete relies on Automation.json's waitForNavigationToComplete returning either WindowNotFound or FrameNotFound to update its internal state.
After 306469@main, it now returns WindowNotFound also for non-existent frames. This causes WebDriver::Session to think that the whole window was closed, breaking ~40 tests, mostly "test_no_browsing_context" variants.
Tentative patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/59625
EWS
Committed 308405@main (9d4b276bf129): <https://commits.webkit.org/308405@main>
Reviewed commits have been landed. Closing PR #59625 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/171427058>