Bug 308498
| Summary: | [Safer-CPP] PR comments by bots are confusing due to multiple platforms | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brianna Fan <bfan2> |
| Component: | Tools / Tests | Assignee: | Brianna Fan <bfan2> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brianna Fan
Filing on behalf of Sam Weinig:
"For example, in https://github.com/WebKit/WebKit/pull/59114#issuecomment-3938210833, this comment is for the iOS bot (which I can figure out by spelunking), and tells me to run, Tools/Scripts/update-safer-cpp-expectations -p WebCore --UncheckedCallArgsChecker style/values/viewport/StyleZoomPrimitivesInlines.h , but if I do that, I will break the macOS bot."
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/171020009>
Brianna Fan
Pull request: https://github.com/WebKit/WebKit/pull/59271
EWS
Committed 308137@main (30d987b3e90f): <https://commits.webkit.org/308137@main>
Reviewed commits have been landed. Closing PR #59271 and removing active labels.