Bug 308344
| Summary: | [Grid] Remove RenderGrid::m_baselineItemsCached | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sammy Gill
This field is only used to share a list of baseline aligned grid items between RenderGrid::layoutBlock and RenderGrid::computeIntrinsicLogicalWidths and makes it a bit difficult to rework other parts of the code. If there is no measurable perf benefit then it would probably be better to remove it
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/170837971>
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/59128
EWS
Committed 308078@main (1094f9ce271a): <https://commits.webkit.org/308078@main>
Reviewed commits have been landed. Closing PR #59128 and removing active labels.