Bug 308319
| Summary: | Web Inspector: WebInspectorBackend::Show completion handler must be called | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Qianlang Chen <qianlangchen> |
| Component: | Web Inspector | Assignee: | Qianlang Chen <qianlangchen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Qianlang Chen
According to this, the completion handler for IPC messages must be called once: https://github.com/the-chenergy/WebKit/blob/e2639ef69577f28d66dc711233148970ba221657/Source/WTF/wtf/CompletionHandler.h#L82
The listener for WebInspectorBackend::Show has an early return that bypasses calling the completion handler for that message: https://github.com/WebKit/WebKit/blob/27241564f95710442bd89874714d41f33ca757b8/Source/WebKit/WebProcess/Inspector/WebInspectorBackend.cpp#L138
This was introduced in my work when I was not aware of this rule about completion handlers: https://github.com/apple/WebKit/pull/2291/changes#diff-583ff833eb55165cc11e7d431d26e2bdf7e33656d50530df126e237c4637cc58R135-R142
This should technically trigger that assertion failure on a debug build
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Qianlang Chen
Pull request: https://github.com/WebKit/WebKit/pull/59108
EWS
Committed 307957@main (ff561b3a23fe): <https://commits.webkit.org/307957@main>
Reviewed commits have been landed. Closing PR #59108 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/170854287>