Bug 30826

Summary:

REGRESSION: svn-apply exits(1) when applying a patch with a file add

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

29622

Attachments:

Description	Flags
Patch v1	none

Eric Seidel (no email)

Reported 2009-10-27 10:08:54 PDT

svn-apply git add is failing for the commit-queue I believe the problem is that svn-apply should be run with a CWD of the root of the repository. There is probably a second bug that svn-apply needs to know how to chdir itself to the root of the respository when running in git mode.

Attachments
Patch v1 (3.52 KB, patch) 2009-10-27 10:30 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-10-27 10:26:40 PDT

This was caused by a bad patch for bug 29622. I'll post a fix in a sec.

Eric Seidel (no email)

Comment 2 2009-10-27 10:30:42 PDT

Created attachment 41962 [details] Patch v1

Adam Barth

Comment 3 2009-10-27 10:32:25 PDT

Comment on attachment 41962 [details] Patch v1 Ok. Perl is dumb.

WebKit Commit Bot

Comment 4 2009-10-27 10:38:35 PDT

Comment on attachment 41962 [details] Patch v1 Clearing flags on attachment: 41962 Committed r50157: <http://trac.webkit.org/changeset/50157>

WebKit Commit Bot

Comment 5 2009-10-27 10:38:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.