Bug 308249
| Summary: | Fix filter-build-webkit crash when build line has no path argument | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Guard basename() call against undef $4 when the optional path capture group doesn't match, which causes a error from File::Basename, causing the script to crash.
This was manifesting as output stopping and the following error code being emitted, when piping build output through `filter-build-webkit`:
```
Use of uninitialized value $_[0] in substitution (s///) at /System/Library/Perl/5.34/File/Basename.pm line 341, <> line 11967.
fileparse(): need a valid pathname at /Users/z/ws/wk/OpenSource/Tools/Scripts/filter-build-webkit line 188.
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/170756867>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/59031
EWS
Committed 307866@main (06eb9b4c77bf): <https://commits.webkit.org/307866@main>
Reviewed commits have been landed. Closing PR #59031 and removing active labels.