Bug 308116
| Summary: | REGRESSION(302416@main) Adjust Quirks for hotels.com to remove the flickering | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | WebKit Misc. | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | graouts, sam, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://hotels.com/ | ||
| Bug Depends on: | 286995 | ||
| Bug Blocks: | |||
Karl Dubost
Previously in Bug 286995, a quirk was added to remove flickering on hotels.com, this is not working anymore. Something has changed.
The quirks needs to be adjusted.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
<rdar://170331800>
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/58913
Antoine Quint
Some history:
- 289777@main (fix for bug 286995) was when the original quirk landed, which correctly applied the animations but had a slight flash at the beginning.
- 300237@main (fix for bug 298838) by Sam Weinig was when the flash was removed and hotels.com was in the best state in Safari, matching Chrome’s behavior.
- 302416@main (fix for bug 301581) also by Sam Weinig was when things regressed to the current state :(
Perhaps the code added in 289777@main was no longer optimal with how the style system works with animations anymore, or perhaps it's actually a bad regression we must fix. I think we need to understand what’s wrong with the original Quirks code before making a change and engage with Sam Weinig, the author of 302416@main, to get to the bottom of this. I've Cc'd him to this bug and left a comment on bug 301581.
Karl Dubost
The steps to reproduce are missing
1. Launch Safari
2. Navigate to hotels.com
3. In the top left corner of the website, tap “shop travel”
Results:
It should not flicker. It does flicker again.
EWS
Committed 308678@main (381ad0cbb2cd): <https://commits.webkit.org/308678@main>
Reviewed commits have been landed. Closing PR #58913 and removing active labels.