Bug 308034
| Summary: | [SaferCPP] Fix some UncountedCallArgsChecker in Source/WebCore/Modules/webaudio/ | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ruthvik Konda <rkonda2> |
| Component: | New Bugs | Assignee: | Ruthvik Konda <rkonda2> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ruthvik Konda
Fix UncountedCallArgsChecker warnings in 4 files in Source/WebCore/Modules/webaudio/:
- AudioBasicProcessorNode.cpp: protect bus() for pull() call argument
- AudioContext.cpp: nested protect() for window() and performance()
- AudioNodeInput.cpp: protect m_internalSummingBus for zero() call
- AudioWorkletGlobalScope.cpp: protect wrapped() for ThreadSafeWeakHashSet::add()
Using protect() because the functions involved are complex/non-trivial or may trigger deallocation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ruthvik Konda
[SaferCPP] Fix some UncountedCallArgsChecker in Source/WebCore/Modules/webaudio/.
Radar WebKit Bug Importer
<rdar://problem/170528740>
Ruthvik Konda
Pull request: https://github.com/WebKit/WebKit/pull/58838
EWS
Committed 307740@main (dd7df5777c23): <https://commits.webkit.org/307740@main>
Reviewed commits have been landed. Closing PR #58838 and removing active labels.