Bug 308026
| Summary: | [macOS Release] http/tests/webgpu/webgpu/shader/validation/functions/restrictions.html is a flaky text failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego De La Toba <d_delatoba> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego De La Toba
http/tests/webgpu/webgpu/shader/validation/functions/restrictions.html is a flaky text failure on macOS release
HISTORY:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fwebgpu%2Fwebgpu%2Fshader%2Fvalidation%2Ffunctions%2Frestrictions.html
TEXT DIFF:
--- /Volumes/Data/worker/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/webgpu/webgpu/shader/validation/functions/restrictions-expected.txt
+++ /Volumes/Data/worker/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/webgpu/webgpu/shader/validation/functions/restrictions-actual.txt
@@ -159,6 +159,8 @@
PASS :function_parameter_types:case="invalid_ptr6"
PASS :function_parameter_types:case="invalid_ptr7"
FAIL :function_parameter_types:case="invalid_ptr8" assert_unreached:
+ - EXPECTATION FAILED: Expected validation error
+ at (elided: below max severity)
- VALIDATION FAILED: Missing expected compilationInfo 'error' message.
@@ -194,8 +196,6 @@
}
expectCompileResult@http://127.0.0.1:8000/webgpu/webgpu/shader/validation/shader_validation_test.js:73:28
@http://127.0.0.1:8000/webgpu/webgpu/shader/validation/functions/restrictions.spec.js:313:24
- - EXPECTATION FAILED: Expected validation error
- at (elided: below max severity)
Reached unreachable code
PASS :function_parameter_matching:decl="u32"
PASS :function_parameter_matching:decl="i32"
DIFF URL:
https://build.webkit.org/results/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/307676%40main%20(1732)/http/tests/webgpu/webgpu/shader/validation/functions/restrictions-pretty-diff.html
REPRODUCTION:
I was able to reproduce this on macOS Tahoe ToT with the following:
run-webkit-tests --release --no-retry --force --iterations 2000 --exit-after-n-failures=1 -f http/tests/webgpu/webgpu/shader/validation/functions/restrictions.html
I am going to mark expectations as pass fail while this pends investigation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/170521658>
Diego De La Toba
Pull request: https://github.com/WebKit/WebKit/pull/58832
EWS
Test gardening commit 307682@main (c213d355a730): <https://commits.webkit.org/307682@main>
Reviewed commits have been landed. Closing PR #58832 and removing active labels.
Diego De La Toba
This appears to be a test issue where shader_validation_test.js is performing two async validation checks in parallel (GPU validation error check and compilation info message check). Since both operations run asynchronously and independently, their error messages could be logged in different orders depending on timing, causing intermittent text diff failures.
Diego De La Toba
Pull request: https://github.com/WebKit/WebKit/pull/58834
EWS
Committed 307878@main (8e292742055c): <https://commits.webkit.org/307878@main>
Reviewed commits have been landed. Closing PR #58834 and removing active labels.