Bug 307860
| Summary: | [appearance: base] Resolve and update the appearance: base pseudo elements by default | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Forms | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Said Abou-Hallawa
The commit 306440@main caused a Speedometer3 regression. The commit 307019@main enabled resolving and updating the ::checkmark pseudo element only when cssAppearanceBaseEnabled is on.
To enable cssAppearanceBaseEnabled by default, resolving and updating the ::checkmark pseudo element should not rely on the feature flag cssAppearanceBaseEnabled anymore. Instead we can check the style appearance value. If its value is "base", we are allowed to resolve and update the checkmark.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
rdar://170018554
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/58679
EWS
Committed 307540@main (e5a6ab833409): <https://commits.webkit.org/307540@main>
Reviewed commits have been landed. Closing PR #58679 and removing active labels.