Bug 307822 – REGRESSION(307236@main): [Tahoe] webanimations/no-scheduling-while-filling-non-accelerated.html is a flaky text failure

• Component: Animations
• Status: RESOLVED FIXED

[Diego De La Toba]

webanimations/no-scheduling-while-filling-non-accelerated.html is a flaky text failure on macOS Tahoe.


HISTORY:
https://results.webkit.org/?suite=layout-tests&test=webanimations%2Fno-scheduling-while-filling-non-accelerated.html


TEXT DIFF:
--- /Volumes/Data/worker/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/build/layout-test-results/webanimations/no-scheduling-while-filling-non-accelerated-expected.txt
+++ /Volumes/Data/worker/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/build/layout-test-results/webanimations/no-scheduling-while-filling-non-accelerated-actual.txt
@@ -1,3 +1,3 @@
 
-PASS There should not be any updates made to the timeline after a forward-filling animation completes.
+FAIL There should not be any updates made to the timeline after a forward-filling animation completes. assert_equals: expected 1 but got 2
 

DIFF URL:
https://build.webkit.org/results/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/307378%40main%20(829)/webanimations/no-scheduling-while-filling-non-accelerated-pretty-diff.html


REPRODUCTION:
I was able to reproduce this on macOS Tahoe Debug ToT with the following:

run-webkit-tests --debug --no-retry --force --iterations 4000 -f  webanimations/no-scheduling-while-filling-non-accelerated.html

I am going to mark expectations as pass fail while this pends investigation.

[Radar WebKit Bug Importer]

<rdar://problem/170329998>

[Diego De La Toba]

Pull request: https://github.com/WebKit/WebKit/pull/58645

[EWS]

Test gardening commit 307495@main (1e4c3a7f9524): <https://commits.webkit.org/307495@main>

Reviewed commits have been landed. Closing PR #58645 and removing active labels.

[Antoine Quint]

This only happens with `-f`, a single process seems to be solid. And disabling "Threaded Time-based Animations" in the test makes it pass without a hitch, so there's no doubt about the cause.

[Antoine Quint]

Logging indicates we are sometimes scheduling frames because we have pending threaded animations updates… but this test should not schedule threaded animations ever since it's only animating margin-left. This is likely the cause of this failure.

[Antoine Quint]

Pull request: https://github.com/WebKit/WebKit/pull/58914

[EWS]

Committed 307758@main (7bcd19f3fd56): <https://commits.webkit.org/307758@main>

Reviewed commits have been landed. Closing PR #58914 and removing active labels.