Bug 30778 – GraphicsContext3D should be using fastMalloc

• Component: WebGL
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

GraphicsContext3D has a bunch of malloc() calls that should be using fastMalloc.

[Chris Marrin]

Landed in http://trac.webkit.org/changeset/51535

[Chris Marrin]

Sorry, closed wrong bug. Ignore previous comment

[Chris Marrin]

Created attachment 44074 [details]
Patch with updated test case

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44074 [details] without any errors.

[Adam Roben (:aroben)]

Comment on attachment 44074 [details]
Patch with updated test case

> -    GLchar* info = (GLchar*) malloc(length);
> +    GLchar* info = (GLchar*) fastMalloc(length);
> +    if (!info)
> +        return "";
> +
>      ::glGetProgramInfoLog((GLuint) program->object(), length, &size, info);
>      String s(info);
>      free(info);

If you use fastMalloc, you need to use fastFree, too.

[Adam Roben (:aroben)]

Comment on attachment 44074 [details]
Patch with updated test case

> +// Test program and shader gets
> +var parseError = "ERROR: 0:1: 'I' : syntax error syntax error\nERROR: Parser found no code to compile in source strings.\n";
> +var errorVertString = "I am a bad vertex shader\n";
> +var errorFragString = "I am a bad fragment shader\n";
> +shouldBe('gl.getProgramInfoLog(standardProgram)', '""');
> +shouldBe('gl.getShaderInfoLog(errorVert)', 'parseError');
> +shouldBe('gl.getShaderInfoLog(errorFrag)', 'parseError');
> +shouldBe('gl.getShaderSource(errorVert)', 'errorVertString');
> +shouldBe('gl.getShaderSource(errorFrag)', 'errorFragString');

If you don't quote the second parameter to these functions you'll see the actual error messages in the test output, which might be good. Maybe you should be using shouldBeEqualToString instead?

[Chris Marrin]

Created attachment 44079 [details]
Replacement patch

Adds fastFree

[Adam Roben (:aroben)]

Comment on attachment 44079 [details]
Replacement patch

r=me

[Chris Marrin]

Landed in http://trac.webkit.org/changeset/51537