Bug 30777

Summary: [Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
proposed patch
none
2nd try none

Laszlo Gombos
Reported 2009-10-26 08:54:39 PDT
To reproduce the original crash do the following: - Build QtWebKit on Windows in debug mode - Launch QtLauncher and navigate to http://html5demos.com/database The crash backtrace revealed that SQLiteDatabase::setMaximumSize failed as "PRAGMA max_page_count .." SQLiteStatement was malformed because String::number(newMaxPageCount) returned "%I64u". This is because on WIN_OS "long long" is formatted using "%I64u" and Qt's QString::vsprintf does not seems to understand this format string. Using the "%lli" to format "long long" types fixes the problem.
Attachments
proposed patch (1.41 KB, patch)
2009-10-26 10:18 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
2nd try (1.55 KB, patch)
2009-10-26 14:06 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-10-26 10:18:10 PDT
Created attachment 41875 [details] proposed patch
Laszlo Gombos
Comment 2 2009-10-26 14:06:04 PDT
Created attachment 41895 [details] 2nd try Update the ChangeLog to describe the patch better.
Eric Seidel (no email)
Comment 3 2009-10-26 14:46:27 PDT
Comment on attachment 41895 [details] 2nd try OK. I'll believe you.
WebKit Commit Bot
Comment 4 2009-10-26 15:22:56 PDT
Comment on attachment 41895 [details] 2nd try Clearing flags on attachment: 41895 Committed r50103: <http://trac.webkit.org/changeset/50103>
WebKit Commit Bot
Comment 5 2009-10-26 15:23:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.