Bug 30762

Summary:

Visual Studio Projects don't properly build with ENABLE_FILTER support

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, jeffschiller, krit

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows Vista

Bug Depends on:

Bug Blocks:

68469, 26389

Attachments:

Description	Flags
Correct some build issues for ENABLE_FILTERS under Windows.	aroben: review+

Brent Fulgham

Reported 2009-10-25 19:52:18 PDT

The various graphical filter elements are not properly built by WebCore.vcproj when ENABLE_FILTERS is defined. The main issues are that some key files are not included in the build, and some include paths are not provided by the Visual Studio property files. These issues appear to be the result of the main FILTERS development not being tracked in the Windows side of things.

Attachments
Correct some build issues for ENABLE_FILTERS under Windows. (12.54 KB, patch) 2009-10-25 20:02 PDT, Brent Fulgham	aroben: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2009-10-25 20:02:17 PDT

Created attachment 41837 [details] Correct some build issues for ENABLE_FILTERS under Windows.

Adam Roben (:aroben)

Comment 2 2009-10-26 08:39:59 PDT

Comment on attachment 41837 [details] Correct some build issues for ENABLE_FILTERS under Windows. r=me

Brent Fulgham

Comment 3 2009-10-26 13:47:25 PDT

Committed in http://trac.webkit.org/changeset/50085.

Note You need to log in before you can comment on or make changes to this bug.