Bug 307385
| Summary: | [MacOS] fast/events/onunload-not-on-body.html is a flaky text failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego De La Toba <d_delatoba> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego De La Toba
fast/events/onunload-not-on-body.html is a flaky text failure across all architectures and styles.
HISTORY:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fonunload-not-on-body.html
TEXT DIFF:
--- /Volumes/Data/worker/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/build/layout-test-results/fast/events/onunload-not-on-body-expected.txt
+++ /Volumes/Data/worker/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/build/layout-test-results/fast/events/onunload-not-on-body-actual.txt
@@ -1,3 +1,3 @@
-frame "<!--frame3-->" - has 1 onunload handler(s)
+frame "<!--frame4-->" - has 1 onunload handler(s)
CONSOLE MESSAGE: Use of window.alert is not allowed while unloading a page.
you should only see one unload alert appear.
DIFF URL:
https://build.webkit.org/results/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/307099%40main%20(1543)/fast/events/onunload-not-on-body-pretty-diff.html
REPRODUCTION:
I was able to reproduce this failure on macOS Tahoe ToT arm64 with the following:
run-webkit-tests --force --release --no-retry --iterations 1000 fast/events/onunload-not-on-body.html
I am going to mark expectations as pass fail while this pends investigation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/170008549>
Diego De La Toba
Pull request: https://github.com/WebKit/WebKit/pull/58252
EWS
Test gardening commit 307119@main (8275904a69cf): <https://commits.webkit.org/307119@main>
Reviewed commits have been landed. Closing PR #58252 and removing active labels.
Diego De La Toba
Pull request: https://github.com/WebKit/WebKit/pull/58254
Diego De La Toba
Looks like the test is flaky because it relies on an auto-generated frame identifier (frame3 or frame4) & this is causing the frame number to vary between runs. I’m going to push a patch that resolves this, please review (assuming this is NOT a webkit issue).