Bug 30738

Summary:

"Evaluate selection" feature is broken

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, pfeldman, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Yury Semikhatsky

Reported 2009-10-23 22:52:53 PDT

Steps to reproduce: 1. Pause script on a breakpoint. 2. Select some expression in the current function source code. 3. Press Cmd+Shift+'E' on Mac or Ctrl+Shift+'E' on Win. Expected: expression result is printed in the console. Actual: nothing happens. This is a regression introduced in https://bugs.webkit.org/show_bug.cgi?id=29891 WebInspector.SourceFrame.prototype._evalSelectionInCallFrame should pass objectGroup as third parameter when it is calling WebInspector.panels.scripts.evaluateInSelectedCallFrame.

Attachments
patch (1.35 KB, patch) 2009-10-26 09:02 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2009-10-26 09:02:53 PDT

Created attachment 41869 [details] patch

WebKit Commit Bot

Comment 2 2009-10-26 09:17:38 PDT

Comment on attachment 41869 [details] patch Clearing flags on attachment: 41869 Committed r50065: <http://trac.webkit.org/changeset/50065>

WebKit Commit Bot

Comment 3 2009-10-26 09:17:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.