Bug 307362

Summary:	REGRESSION(Xcode 26): Broke WebPushD tests (ASSERTION FAILED: m_shouldIncrementProtocolVersionForTesting)
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Elliott Williams <emw>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	beidson, nham, sihui_liu, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Jonathan Bedard

Reported 2026-02-09 12:37:20 PST

After updating our Sequoia builders to Xcode 26, we are seeing a number of WebPushD test failures. History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebPushD.BasicCommunication CI build: https://build.webkit.org/#/builders/1226/builds/3286 Log: 08:21:47.534 45133 TestWebKitAPI.WebPushD.BasicCommunication 08:21:47.534 45133 2026-02-09 08:15:36.082 TestWebKitAPI[68028:3288098] NSEventConcurrentProcessingEnabled=NO 08:21:47.534 45133 ASSERTION FAILED: m_shouldIncrementProtocolVersionForTesting 08:21:47.534 45133 /Volumes/Data/worker/Apple-Sequoia-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm(479) : auto TestWebKitAPI::WebPushXPCConnectionMessageSender::sendWithAsyncReplyWithoutUsingIPCConnection(Messages::PushClientConnection::GetPushTopicsForTesting &&, void (^&&)(WTF::Vector<WTF::String>, WTF::Vector<WTF::String>))::(anonymous class)::operator()(xpc_object_t) 08:21:47.534 45133 1 0x1043c28cc void TestWebKitAPI::WebPushXPCConnectionMessageSender::sendWithAsyncReplyWithoutUsingIPCConnection<Messages::PushClientConnection::GetPushTopicsForTesting, void (WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>) block_pointer>(Messages::PushClientConnection::GetPushTopicsForTesting&&, void (WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>) block_pointer&&) const::'lambda'(NSObject<OS_xpc_object>*)::operator()(NSObject<OS_xpc_object>*) 08:21:47.534 45133 2 0x1043c2c04 WTF::BlockPtr<void (NSObject<OS_xpc_object>*)> WTF::BlockPtr<void (NSObject<OS_xpc_object>*)>::fromCallable<void TestWebKitAPI::WebPushXPCConnectionMessageSender::sendWithAsyncReplyWithoutUsingIPCConnection<Messages::PushClientConnection::GetPushTopicsForTesting, void (WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>) block_pointer>(Messages::PushClientConnection::GetPushTopicsForTesting&&, void (WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>) block_pointer&&) const::'lambda'(NSObject<OS_xpc_object>*)>(Messages::PushClientConnection::GetPushTopicsForTesting)::'lambda'(void*, NSObject<OS_xpc_object>*)::operator()(void*, NSObject<OS_xpc_object>*) const 08:21:47.534 45133 3 0x1043c2bd0 WTF::BlockPtr<void (NSObject<OS_xpc_object>*)> WTF::BlockPtr<void (NSObject<OS_xpc_object>*)>::fromCallable<void TestWebKitAPI::WebPushXPCConnectionMessageSender::sendWithAsyncReplyWithoutUsingIPCConnection<Messages::PushClientConnection::GetPushTopicsForTesting, void (WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>) block_pointer>(Messages::PushClientConnection::GetPushTopicsForTesting&&, void (WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>) block_pointer&&) const::'lambda'(NSObject<OS_xpc_object>*)>(Messages::PushClientConnection::GetPushTopicsForTesting)::'lambda'(void*, NSObject<OS_xpc_object>*)::__invoke(void*, NSObject<OS_xpc_object>*) 08:21:47.534 45133 4 0x19c363f18 _xpc_connection_reply_callout 08:21:47.534 45133 5 0x19c363e08 _xpc_connection_call_reply_async 08:21:47.534 45133 6 0x19c4bd88c _dispatch_client_callout3_a 08:21:47.534 45133 7 0x19c4c186c _dispatch_mach_msg_async_reply_invoke 08:21:47.534 45133 8 0x19c4daaa4 _dispatch_main_queue_drain.cold.5 08:21:47.534 45133 9 0x19c4b2db0 _dispatch_main_queue_drain 08:21:47.534 45133 10 0x19c4b2cec _dispatch_main_queue_callback_4CF 08:21:47.534 45133 11 0x19c784b30 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ 08:21:47.534 45133 12 0x19c74582c __CFRunLoopRun 08:21:47.534 45133 13 0x19c7449e8 CFRunLoopRunSpecific 08:21:47.534 45133 14 0x19dd14c78 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 08:21:47.534 45133 15 0x1045275f8 TestWebKitAPI::Util::run(bool*) 08:21:47.534 45133 16 0x10438608c TestWebKitAPI::WebPushD_BasicCommunication_Test::TestBody() 08:21:47.534 45133 17 0x10461da88 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 08:21:47.534 45133 18 0x1045dacf4 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 08:21:47.534 45133 19 0x1045dac44 testing::Test::Run() 08:21:47.534 45133 20 0x1045dbb74 testing::TestInfo::Run() 08:21:47.534 45133 21 0x1045dcc48 testing::TestSuite::Run() 08:21:47.534 45133 22 0x1045ea9e4 testing::internal::UnitTestImpl::RunAllTests() 08:21:47.534 45133 23 0x104622734 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 08:21:47.534 45133 24 0x1045ea3dc bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 08:21:47.534 45133 25 0x1045ea2d4 testing::UnitTest::Run() 08:21:47.534 45133 26 0x1036bbca8 RUN_ALL_TESTS() 08:21:47.534 45133 27 0x1036bbc40 TestWebKitAPI::TestsController::run(int, char**) 08:21:47.534 45133 28 0x1045c31e8 main 08:21:47.534 45133 29 0x19c2bab98 start

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2026-02-09 12:37:34 PST

<rdar://problem/169991396>

Marta Darbinyan

Comment 2 2026-02-09 14:22:48 PST

Pull request: https://github.com/WebKit/WebKit/pull/58238

Elliott Williams

Comment 3 2026-02-11 12:43:04 PST

Pull request: https://github.com/WebKit/WebKit/pull/58432

EWS

Comment 4 2026-02-12 16:16:38 PST

Committed 307416@main (ce27b7cfad2d): <https://commits.webkit.org/307416@main> Reviewed commits have been landed. Closing PR #58432 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.