Bug 30736

Summary: Web Inspector: remove double click to re-root the tree
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, commit-queue, joepeck, pfeldman, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch none

Timothy Hatcher
Reported 2009-10-23 20:18:38 PDT
We should remove double click to re-root the tree. THis has bitten me while trying to edit attributes and text nodes. If you miss, you will re-root the tree and it is surprising to new users and annoying to fix. We should remove it completly or religate it to the bread crumbs, so double click on them will re-root.
Attachments
Proposed Patch (1.36 KB, patch)
2009-10-24 09:51 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-10-23 22:14:11 PDT
+1 on removing them. not sure we need it in crumbs.
Brian Weinstein
Comment 2 2009-10-23 22:15:30 PDT
Agreed on removing it. Do developers use it a lot? Is this something we should post on webkit-dev?
Timothy Hatcher
Comment 3 2009-10-23 23:21:28 PDT
Let remove it and see if anyone notices it.
Joseph Pecoraro
Comment 4 2009-10-23 23:53:55 PDT
+1 to removing. I have never intentionally used the feature and get surprised every time it happens =). I just haven't found a use case for it that isn't handled by the full tree and expanding. Really deep nesting? Not a problem when docked and I would just resize if undocked.
Timothy Hatcher
Comment 5 2009-10-24 09:51:23 PDT
Created attachment 41782 [details] Proposed Patch
WebKit Commit Bot
Comment 6 2009-10-24 16:02:55 PDT
Comment on attachment 41782 [details] Proposed Patch Clearing flags on attachment: 41782 Committed r50031: <http://trac.webkit.org/changeset/50031>
WebKit Commit Bot
Comment 7 2009-10-24 16:03:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.