Bug 307347
| Summary: | [check-webkit-style] Fix false positive in safercpp/protected_getter_for_init checker | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 306787 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
The `check-webkit-style` script produces false positives for code like:
```cpp
if (RefPtr document = viewportDocumentForFrame(protect(mainFrame())))
```
Error message:
```
error: [safercpp/protected_getter_for_init] Do not use protect() for variable initialization.
```
This is a false positive because `protect(mainFrame())` is an argument to `viewportDocumentForFrame()`, not the direct initializer for `document`.
The checker should only warn when `protect()`, `protectedFoo()`, or `checkedFoo()` functions are used as the direct initializer, not when they are nested inside other function calls.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/169975626>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/58222
EWS
Committed 307125@main (d93063803637): <https://commits.webkit.org/307125@main>
Reviewed commits have been landed. Closing PR #58222 and removing active labels.