Bug 307323
| Summary: | Add clang-target argument | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | adrian_taylor |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
adrian_taylor
In Swift/C++ interop, swiftc uses an embedded version of clang to interpret WebKit's headers. Some of those headers depend upon macros such as __MAC_OS_X_VERSION_MIN_REQUIRED, and these can be very impactful e.g. adding or removing data members from structures and thus changing offsets of later data members. Unfortunately clang modules attempt to be agnostic to MacOS versions, and thus these macros were not representing the actual target SDK version; therefore Swift and C++ ended up with different ideas about the offsets of data members. All of this is explored in rdar://168992837. For now, the workaround is to force Swift to give a specific SDK version number to clang, and this bug represents the task of doing that.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/169955071>
adrian_taylor
Pull request: https://github.com/WebKit/WebKit/pull/58188
EWS
Committed 307153@main (43463e2bf5a4): <https://commits.webkit.org/307153@main>
Reviewed commits have been landed. Closing PR #58188 and removing active labels.