Bug 307281
| Summary: | inkOverflowForDecorations() should use its own return type distinct from GlyphOverflow | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | Layout and Rendering | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 307002 | ||
Gerald Squelart
inkOverflowForDecorations() is using GlyphOverflow as output, but it was probably for convenience, as it doesn't share code paths with other users of GlyphOverflow going through FontCascade::width(), and it doesn't need the `computeBounds` member.
Instead it should return its own data type.
This will help with bug 307002, where GlyphOverflow may be further improved.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/169927130>
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/58137
EWS
Committed 307046@main (4af680358f82): <https://commits.webkit.org/307046@main>
Reviewed commits have been landed. Closing PR #58137 and removing active labels.