Bug 30718 – WebKit should build with Visual Studio 2010

• Component: WebKit Misc.
• Status: RESOLVED WORKSFORME

[Steve Falkenburg]

We should make the WebKit Windows build compatible with Visual Studio 2010.
B2 is available for download now to MSDN subscribers.

[Steve Falkenburg]

Several issues block seamless conversion to VS2010 using the conversion tool:

Projects converted from VS2008 to VS2010 are missing inherited property sheets
<https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=498791>

AdditionalIncludeDirectories in vsprops files not properly converted
<https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=500197>

[Steve Falkenburg]

Also:

Files excluded from all targets cause conversion difficulty for vcproj conversion to vcxproj
<https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=500334>

Created attachment 44219 [details]
Build error using VS2010/x64 when building QtWebKit from Qt 4.6.0

I just tried to build Qt 4.6.0 with Visual Studio, it works fine with VS 2008/x64, but VS 2010/x64 fails to compile.

[John Brooks]

After some insight from Thiago Macieira of Nokia, I did a little testing and isolated the compilation failure in comment #3 to what seems to be a compiler bug. Specifically, during the initialization of std::pair (for reasons unknown to me), the implicit conversion from 0 to a pointer type is not performed, resulting in those errors. An explicit cast or nullptr behaves as expected.

I've reported that bug to microsoft at https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=520043

[John Brooks]

According to the response to the compiler bug submitted in comment #4, it seems that Microsoft recognizes but cannot fix that compilation issue for VS2010. The full reply can be read there.

Be it sooner or later, it will be necessary to fix this in some way for VS2010 compilation to work. The bug specifically involves the use of a 0 literal in the std::pair constructor, and can be worked around using the new nullptr keyword (which is not compatible with any non-C++0x compiler) or by casting the literal explicitly. The latter seems like the obvious solution, and as this issue is holding back Qt and other software from compiling under VS2010, that minor fix would be better sooner than later.

I would appreciate if someone in a better position to build webkit were to look into patching that, but if not, I will do so when time permits.

[Jarred Nicholls]

Unless I'm mistaken, this isn't an issue anymore...?

[Jarred Nicholls]

Confident that QtWebKit builds with Visual Studio 2010, so I'm going to close this bug.