[Qt] Windowless Plugins : Don't use m_clipRect when painting.

• Component: Plug-ins
• Status: RESOLVED FIXED

[Girish Ramakrishnan]

Though it works, it is not correct to use m_clipRect for painting in Windowless mode. Instead, the rect paramater that is passed as a part of PluginView::paint() must be used. This change will also result in some speedup since previously we used to paint all the visible parts of a windowless plugin (even if those parts are not dirty).

[Girish Ramakrishnan]

Created attachment 41720 [details]
[Qt] Windowless Plugins : Don't use m_clipRect when painting.


Though it works, it is not correct to use m_clipRect for painting
in Windowless mode. Instead, the rect paramater that is passed
as a part of PluginView::paint() must be used. This change will
also result in some speedup since previously we used to paint all
the visible parts of a windowless plugin (even if those parts are
not dirty).

https://bugs.webkit.org/show_bug.cgi?id=30711
---
 WebCore/ChangeLog                   |   19 +++++++++++++++++++
 WebCore/plugins/qt/PluginViewQt.cpp |   23 +++++++++++++----------
 2 files changed, 32 insertions(+), 10 deletions(-)

[Girish Ramakrishnan]

Created attachment 41721 [details]
[Qt] Windowless Plugins : Don't use m_clipRect when painting (2)

ChangeLog updated based on Holger's comments.

[Holger Freyther]

Comment on attachment 41721 [details]
[Qt] Windowless Plugins : Don't use m_clipRect when painting (2)

The exposedRect.move took some time to get around to. Due the clipping we can not simply use IntRect(0, 0, width, height())... Patch seems fine.

[WebKit Commit Bot]

Comment on attachment 41721 [details]
[Qt] Windowless Plugins : Don't use m_clipRect when painting (2)

Rejecting patch 41721 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11506 test cases.
fast/media/mq-transform-02.html -> failed

Exiting early after 1 failures. 7441 tests run.
139.46s total testing time

7440 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output

[Holger Freyther]

Landed in r49974.

[Eric Seidel (no email)]

Comment on attachment 41721 [details]
[Qt] Windowless Plugins : Don't use m_clipRect when painting (2)

Sorry about the commit-queue trouble.  Should work fine now.