Bug 30706

Summary: [Qt] Plugins: Use the window's winId() for NPNVnetscapeWindow
Product: WebKit Reporter: Girish Ramakrishnan <girish>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: zecke
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
[Qt] Plugins : Use window's winId() instead of the widget's.
none
[Qt] Plugins : Use window's winId() instead of the widget's. zecke: review+, eric: commit-queue+

Girish Ramakrishnan
Reported 2009-10-22 22:00:25 PDT
Patch follows.
Attachments
[Qt] Plugins : Use window's winId() instead of the widget's. (689 bytes, patch)
2009-10-22 22:07 PDT, Girish Ramakrishnan 		no flags
DetailsFormatted DiffDiff
[Qt] Plugins : Use window's winId() instead of the widget's. (1.54 KB, patch)
2009-10-22 22:12 PDT, Girish Ramakrishnan 		zecke: review+
eric: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Girish Ramakrishnan
Comment 1 2009-10-22 22:07:08 PDT
Created attachment 41713 [details] [Qt] Plugins : Use window's winId() instead of the widget's. As per, https://developer.mozilla.org/en/NPN_GetValue NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the plug-in is displayed; returns Window". The issue was found because NPNVNetscapeWindow winId() ends up creating a native window resulting in flicker. --- WebCore/plugins/qt/PluginViewQt.cpp | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Girish Ramakrishnan
Comment 2 2009-10-22 22:12:46 PDT
Created attachment 41714 [details] [Qt] Plugins : Use window's winId() instead of the widget's. As per, https://developer.mozilla.org/en/NPN_GetValue NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the plug-in is displayed; returns Window". The issue was found because NPNVNetscapeWindow winId() ends up creating a native window resulting in flicker. --- WebCore/ChangeLog | 18 ++++++++++++++++++ WebCore/plugins/qt/PluginViewQt.cpp | 2 +- 2 files changed, 19 insertions(+), 1 deletions(-)
Girish Ramakrishnan
Comment 3 2009-10-22 22:13:50 PDT
Comment on attachment 41714 [details] [Qt] Plugins : Use window's winId() instead of the widget's. Forgot ChangeLog in other patch.
Holger Freyther
Comment 4 2009-10-22 22:43:27 PDT
Comment on attachment 41714 [details] [Qt] Plugins : Use window's winId() instead of the widget's. Okay, I hope we don't need a NULL check and Gtk/X11 seems to do the right thing too.
WebKit Commit Bot
Comment 5 2009-10-23 02:50:15 PDT
Comment on attachment 41714 [details] [Qt] Plugins : Use window's winId() instead of the widget's. Rejecting patch 41714 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 135.99s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output
Holger Freyther
Comment 6 2009-10-23 03:09:09 PDT
Comment on attachment 41714 [details] [Qt] Plugins : Use window's winId() instead of the widget's. The failing test must be unrelated to this change. I hope it is appropriate to try again.
WebKit Commit Bot
Comment 7 2009-10-23 03:13:52 PDT
Comment on attachment 41714 [details] [Qt] Plugins : Use window's winId() instead of the widget's. Rejecting patch 41714 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 134.54s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output
Holger Freyther
Comment 8 2009-10-23 05:04:21 PDT
Landed in r49975.
Eric Seidel (no email)
Comment 9 2009-10-23 12:02:31 PDT
Comment on attachment 41714 [details] [Qt] Plugins : Use window's winId() instead of the widget's. Sorry about the commit-queue trouble. Should work fine now.
Note You need to log in before you can comment on or make changes to this bug.