Bug 307051
| Summary: | [CMake] Avoid confusing message about Ruby not being found | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | zimmermann |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrian Perez
When CMake searches for Ruby, typically it can happen that it is reported as not found:
-- The CMake build type is: Release
-- Could NOT find Ruby (missing: Ruby_INCLUDE_DIR Ruby_LIBRARY Ruby_CONFIG_INCLUDE_DIR) (found suitable version "3.2.3", minimum required is "2.5")
-- Enabling ccache: Setting ccache prefix for compiler.
But then only the Ruby executable is needed, as per the comment in WebKitCommon.cmake:
# We cannot check for RUBY_FOUND because it is set only when the full package is installed and
# the only thing we need is the interpreter. Unlike Python, cmake does not provide a macro
# for finding only the Ruby interpreter.
We could improve this by passing the QUIET flag to find_package() and print the message ourselves after checking the version.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/57946
EWS
Committed 306869@main (6b1a9bc0ba60): <https://commits.webkit.org/306869@main>
Reviewed commits have been landed. Closing PR #57946 and removing active labels.