Bug 30699

Summary:

Add a media layout test asserting that pause has an immediate effect

Product:

WebKit

Reporter:

Andrew Scherkus <scherkus>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Round 1	none
Round 1 - no tabs	none

Description Andrew Scherkus 2009-10-22 17:42:04 PDT

While investigating media layout tests I came across an interesting intermittent bug in Chromium.

Our media backend is written to be as asynchronous as possible.  While this is great most of the time (we don't hang the rendering thread) it also introduced the possibility of the clock still ticking after we issued an asynchronous pause.

I originally stumbled across the bug in video-played-ranges-1.html, but the reason wasn't obvious and I thought the bug had to do with rounding error.  So here's a layout test that asserts that implementors pause their clock immediately.

Comment 1 Andrew Scherkus 2009-10-22 17:46:01 PDT

Created attachment 41703 [details]
Round 1

QuickTime's pause is synchronous so you already pass this test :P

Comment 2 Andrew Scherkus 2009-10-22 17:47:37 PDT

Created attachment 41704 [details]
Round 1 - no tabs

some tabs slipped into my changelog

Comment 3 Eric Carlson 2009-10-22 21:49:08 PDT

Comment on attachment 41704 [details]
Round 1 - no tabs

r=me

Comment 4 WebKit Commit Bot 2009-10-23 02:53:36 PDT

Comment on attachment 41704 [details]
Round 1 - no tabs

Rejecting patch 41704 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11507 test cases.
fast/media/mq-transform-02.html -> failed

Exiting early after 1 failures. 7441 tests run.
138.12s total testing time

7440 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output

Comment 5 Andrew Scherkus 2009-10-23 11:39:25 PDT

Hrmm that commit queue failures doesn't look like it's related.

Comment 6 Eric Seidel (no email) 2009-10-23 12:03:50 PDT

Comment on attachment 41704 [details]
Round 1 - no tabs

Sorry about the commit-queue trouble.  Should work fine now.

Comment 7 WebKit Commit Bot 2009-10-23 13:13:55 PDT

Comment on attachment 41704 [details]
Round 1 - no tabs

Clearing flags on attachment: 41704

Committed r49993: <http://trac.webkit.org/changeset/49993>

Comment 8 WebKit Commit Bot 2009-10-23 13:13:59 PDT

All reviewed patches have been landed.  Closing bug.