Bug 30699

Summary: Add a media layout test asserting that pause has an immediate effect
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Round 1
none
Round 1 - no tabs none

Andrew Scherkus
Reported 2009-10-22 17:42:04 PDT
While investigating media layout tests I came across an interesting intermittent bug in Chromium. Our media backend is written to be as asynchronous as possible. While this is great most of the time (we don't hang the rendering thread) it also introduced the possibility of the clock still ticking after we issued an asynchronous pause. I originally stumbled across the bug in video-played-ranges-1.html, but the reason wasn't obvious and I thought the bug had to do with rounding error. So here's a layout test that asserts that implementors pause their clock immediately.
Attachments
Round 1 (2.78 KB, patch)
2009-10-22 17:46 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Round 1 - no tabs (2.79 KB, patch)
2009-10-22 17:47 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2009-10-22 17:46:01 PDT
Created attachment 41703 [details] Round 1 QuickTime's pause is synchronous so you already pass this test :P
Andrew Scherkus
Comment 2 2009-10-22 17:47:37 PDT
Created attachment 41704 [details] Round 1 - no tabs some tabs slipped into my changelog
Eric Carlson
Comment 3 2009-10-22 21:49:08 PDT
Comment on attachment 41704 [details] Round 1 - no tabs r=me
WebKit Commit Bot
Comment 4 2009-10-23 02:53:36 PDT
Comment on attachment 41704 [details] Round 1 - no tabs Rejecting patch 41704 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11507 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 138.12s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output
Andrew Scherkus
Comment 5 2009-10-23 11:39:25 PDT
Hrmm that commit queue failures doesn't look like it's related.
Eric Seidel (no email)
Comment 6 2009-10-23 12:03:50 PDT
Comment on attachment 41704 [details] Round 1 - no tabs Sorry about the commit-queue trouble. Should work fine now.
WebKit Commit Bot
Comment 7 2009-10-23 13:13:55 PDT
Comment on attachment 41704 [details] Round 1 - no tabs Clearing flags on attachment: 41704 Committed r49993: <http://trac.webkit.org/changeset/49993>
WebKit Commit Bot
Comment 8 2009-10-23 13:13:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.