V8 bindings do not use feature ENABLE guards

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Steve Block]

The V8 bindings in DerivedSourcesAllInOne.cpp, V8Index.cpp/h and DOMObjectsInclude.h (in WebCore/bindings/v8/) do not make consistent use of feature ENABLE guards. This means that the build errors occur when some features are disabled.

The features in question are as follows.
- DATABASE
- WORKERS
- SHARED_WORKERS
- SVG
- XPATH
- XSLT
- INSPECTOR

[Steve Block]

Created attachment 41722 [details]
Patch 1 for Bug 30697

[Eric Seidel (no email)]

Comment on attachment 41722 [details]
Patch 1 for Bug 30697

LGTM.  Nice cleanup!

[Eric Seidel (no email)]

Comment on attachment 41722 [details]
Patch 1 for Bug 30697

Steve is not a committer to marking this cq+ even though he didn't request auto-commit.

[WebKit Commit Bot]

Comment on attachment 41722 [details]
Patch 1 for Bug 30697

Rejecting patch 41722 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
ctsInclude.h
	M	WebCore/bindings/v8/DerivedSourcesAllInOne.cpp
	M	WebCore/bindings/v8/V8Index.cpp
	M	WebCore/bindings/v8/V8Index.h
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/libexec/git-core//git-svn line 469

[Ben Murdoch]

Will land manually to fix up the Changelog.

[Ben Murdoch]

Landed as r50057.