Summary: | Selection draws over content that won't get copied | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Evan Martin <evan> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | ap, hyatt, ivan.stetsenko, michael.vm, pkasting, simon.fraser, tonikitoo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Evan Martin
2009-10-22 16:55:53 PDT
Ojan has been doing work on selection bugs, so he's a good triage person for this. Stopping selection painting at the border box makes sense to me. The downside, I think, is that you'd get a jagged right edge in some cases. For example: <div style="width:200px">foo</div> <div style="width:400px">foo</div> If you were to select all that, then the top part of the selection would be smaller. My intuition is that's a less common case than the cases like this one that it would fix. Seems like hyatt checked in something years ago explicitly to make selection not have jagged edges. I wonder if that patch is the exact opposite of the suggested fix here. (In reply to comment #3) > Seems like hyatt checked in something years ago explicitly to make selection not have jagged edges. I wonder if that patch is the exact opposite of the suggested fix here. These are all heuristics. We need to pick the one that maximizes only highlighting the part of the DOM you have selected while minimizing jagged edges. I expect highlighting the border-box of elements instead of their margin-box would almost always be better. I can easily construct pages where selections would look bad with either approach. Would be great for someone to put together a patch that we could try locally and see how it feels on different real pages. |