Bug 306935
| Summary: | MarkableTraits<WebCore::LayoutUnit>::emptyValue() should use a less common value | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | CSS | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 249919 | ||
| Bug Blocks: | |||
Gerald Squelart
MarkableTraits<WebCore::LayoutUnit>::emptyValue() currently returns LayoutUnit(-1), which is actually quite a valid value corresponding to -1/64 pixels.
Instead it should use a less common value, probably the same as HashTraits<WebCore::LayoutUnit>::emptyValue(), which is INT_MIN and justified as "During the course of layout
// these values are typically only used to represent uninitialized values".
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/169599360>
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/57846
EWS
Committed 306813@main (2d2d923db943): <https://commits.webkit.org/306813@main>
Reviewed commits have been landed. Closing PR #57846 and removing active labels.