Bug 306876
| Summary: | Tweak API calls into Web Back Forward List to respect Swift calling conventions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | adrian_taylor |
| Component: | WebKit Process Model | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 305483 | ||
adrian_taylor
We're building a Swift version of the Web Back Forward List code. Various other parts of WebKit code make method calls on it. Some of those will need tweaks to deal with the slightly different calling conventions that Swift functions have.
Nearly all of these changes are because we can't store a Swift object within a Ref<T> or a RefPtr<T> in C++. We considered making that possible, but given that Swift reference types are automatically reference-counted in C++, it was felt to be too confusing in the long term - even if it had largely obviated the need for these changes in the short term.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/169533837>
adrian_taylor
Pull request: https://github.com/WebKit/WebKit/pull/57787
EWS
Committed 306857@main (5c8edbf5a479): <https://commits.webkit.org/306857@main>
Reviewed commits have been landed. Closing PR #57787 and removing active labels.