Bug 306833
| Summary: | [SVG] Convert SVGTextChunk::ChunkStyle to enum class with OptionSet for type safety | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | SVG | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
The SVGTextChunk class uses an unscoped ChunkStyle enum with unsigned member variable for bitfield operations.
This approach lacks type safety and uses less expressive bitwise operations instead of semantic method calls.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/169502342>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/57755
EWS
Committed 306732@main (e06b3d98e63b): <https://commits.webkit.org/306732@main>
Reviewed commits have been landed. Closing PR #57755 and removing active labels.