Bug 306818
| Summary: | Incorrect outlineWidth in result of getComputedStyle when OutlineStyle is None | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | mechannik512 |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | karlcow, sam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
mechannik512
If OutlineStyle is None, getComputedStyle should return outlineWidth equal to 0, but now it returns 3
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
mechannik512
Pull request: https://github.com/WebKit/WebKit/pull/57740
Sam Weinig
As mentioned in the PR, the current behavior is correct as of CSS UI 4, due to the CSSWG resolution https://github.com/w3c/csswg-drafts/issues/11494.
Is this change in behavior causing an issue for you?
mechannik512
> Is this change in behavior causing an issue for you?
Yes it does (custom JS code of making element screenshot on page, when calculating element coords, includes element outline width, which just changed for all elements)
But since it aligns with CSS UI 4, its not a bug.
mechannik512
Wait, shouldn't we still return "0px" when outline is "none" for compatibility reasons, as described here?
https://github.com/w3c/csswg-drafts/issues/11494#issuecomment-2675800489
Sam Weinig
Perhaps, re-opening this while we take this up with the working group. I filed https://github.com/w3c/csswg-drafts/issues/13451 to start that discussion.
Sam Weinig
mechannik512, are you able to provide a link to the content where this bug is hitting, or is this something that is private?
mechannik512
(In reply to Sam Weinig from comment #6)
> mechannik512, are you able to provide a link to the content where this bug
> is hitting, or is this something that is private?
Not private. Its piece of code where we calculate coords of an element so we could extract that area from viewport screenshot.
Here is link to PR where i fix it on the side of our tool: https://github.com/gemini-testing/testplane/pull/1198/changes