Bug 306603
| Summary: | Remove CanvasBase::m_contextStateSaver, it is not useful | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Canvas | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 275100 | ||
Kimmo Kinnunen
Remove CanvasBase::m_contextStateSaver, it is not useful
GraphicsContextStateSaver is a RAII class, it's not more useful than explicit save/restore useful when managed explicitly.
Having the state saver in CanvasBase makes it harder to move the ImageBuffer from CanvasBase to 2DCanvasRenderingContextBase
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/169252451>
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/57539
EWS
Committed 306511@main (8d32ab8d183e): <https://commits.webkit.org/306511@main>
Reviewed commits have been landed. Closing PR #57539 and removing active labels.