| Summary: | Fix calculation of length in WebSocketChannel.cpp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fumitoshi Ukai <ukai> | ||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Fumitoshi Ukai
2009-10-21 18:42:45 PDT
Created attachment 41627 [details]
Fix calculation of length in WebSocketChannel.cpp
Comment on attachment 41627 [details]
Fix calculation of length in WebSocketChannel.cpp
r=me
Will this covered by layout tests once we have them?
(In reply to comment #2) > (From update of attachment 41627 [details]) > r=me > > Will this covered by layout tests once we have them? Well, how about the following data sequence? 0x81 0x81 0xCC 0x00 "unexpected data" 0xFF It must skip 129 bytes after second 0x81, but wrong code gets 1 as length, so it would receive "unexpected data" unexpectedly. Comment on attachment 41627 [details] Fix calculation of length in WebSocketChannel.cpp Clearing flags on attachment: 41627 Committed r49932: <http://trac.webkit.org/changeset/49932> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 41627 [details] [details]) > > r=me > > > > Will this covered by layout tests once we have them? > > Well, how about the following data sequence? > 0x81 0x81 0xCC 0x00 "unexpected data" 0xFF Oops. should be 0x80 0x81 0x81 0xCC 0x00 "unexpected data" 0xFF > > It must skip 129 bytes after second 0x81, but wrong code gets 1 as length, so > it would receive "unexpected data" unexpectedly. |