Solaris build failure due to strnstr

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Pavel Heimlich (hajma)]

Building QT4.6beta1 on OpenSolaris with Sun Studio12u1 fails with:
"websockets/WebSocketHandshake.cpp", line 255: Error: The function "strnstr" must have a prototype

strnstr is not part of the C++ standard and is not present on solaris.
Other projects test for the presence of this function and eventually reimplement it (see in Aide http://sourceforge.net/projects/aide/files/aide/0.13.1/aide-0.13.1.tar.gz/download)

[Pavel Heimlich (hajma)]

Created attachment 41617 [details]
patch

[Alexey Proskuryakov]

*** Bug 31048 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

Sorry that the patch was ignored for so long. This happened because the patch didn't have review? flag, so it wasn't visible in review queue.

The fix looks right to me.

Could you please submit the patch for review as described in <http://webkit.org/coding/contributing.html>? The change is simple, but someone needs to write a ChangeLog entry for the patch to be landed.

[[e-mail]]

Created attachment 42463 [details]
strnstr patch for Solaris

The patch adds Solaris to the platforms to use the strnstr function of StringExtras since it doesn't provide its own strnstr function. The author of the patch is Pavel Heimlich (hajma).

[[e-mail]]

Bugzilla told me, that I'm not authorized to change hajma's attachment, so I re-attached the patch once again, but now with the review flag.

[Alexey Proskuryakov]

Comment on attachment 42463 [details]
strnstr patch for Solaris

I'm taking this as a "no" to my question about ChangeLog. I'll prepare the patch for landing myself.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/50533>.