Bug 30646
| Summary: | Swedish search (and other languages as well) is broken while fixing Japanese search | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jungshik Shin <jshin> |
| Component: | WebCore Misc. | Assignee: | Jungshik Shin <jshin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | artension, darin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Jungshik Shin
Spun off bug 30437.
Bug 30437 fixed Japanese search for non-Japanese locales. (Japanese Safari was not broken without the patch). However, while doing so, it broke search in Swedish Safari (or many other languages) because the search collator is not locale-dependent any more.
Instead of throwing away the locale-dependent collator and replacing it with UCA + Japanese tailoring (hard-coded in webkit source), we have to get the rule strings for the current locale-dependent collator and concatenate them with the Japanese tailoring (if the current locale is not Japanese).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Darin Adler
Fixed by rolling out in r49926.
Satoshi Nakagawa
(In reply to comment #0)
> Bug 30437 fixed Japanese search for non-Japanese locales. (Japanese Safari was
> not broken without the patch).
Did you mean Safari on Windows?
Because Japanese Safari on Mac is broken without the patch. The collator seems not locale dependent at least in Safari 4.0.3 on Snow Leopard.